New setup #109
Open
New setup #109
+47,560
−19,200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnicolli
approved these changes
Jul 5, 2024
README.md
Outdated
Comment on lines
199
to
207
| ### Volto 18 and later | ||
|
|
||
| Add `volto-form-block` to your add-on `package.json`: | ||
|
|
||
| ```json | ||
| "dependencies": { | ||
| "volto-form-block": "*" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Just to clarify: with volto 18 we still need to add the add-on name to the addons array and to run pnpm add volto-form-block or pnpm install, right?
There was a problem hiding this comment.
yes, the add-on needs to be declared too as usual, the recommended way is to do that in your policy package (inside packages folder.
volto.config.js must have an entry point though, normally pointing to the inner package in packages.
Makefile
Outdated
| .PHONY: backend-docker-start | ||
| backend-docker-start: ## Starts a Docker-based backend for development | ||
| @echo "$(GREEN)==> Start Docker-based Plone Backend$(RESET)" | ||
| docker run -it --rm --name=backend -p 8080:8080 -e SITE=Plone $(DOCKER_IMAGE) |
There was a problem hiding this comment.
This also needs the backend add-on. iirc with -e ADDONS="collective.volto.formsupport"
There was a problem hiding this comment.
@pnicolli let's move the addon in here too, so we have the complete add-on parts in the same repo.
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I promise that once you try the new setup, it's no turning back, and everything else seems so wrong and outdated.
Give it a try!
@pnicolli maybe it's better to merge first the PRs that you told me you have ongoing. Up to you. However, I saw that we have no tests whatsoever, we can fix this too. There are a couple of concerning ESlint failures that I commented out for now, but it would be great to fix it.