WIP: Trying to get yarn start to succeed

collective · Dec 22, 2023 · 9297009 · 9297009
1 parent 7b9490b
commit 9297009
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/.github/workflows/acceptance.yml b/.github/workflows/acceptance.yml
@@ -4,7 +4,7 @@ on: [push]
 env:
   ADDON_NAME: "volto-form-block"
   ADDON_PATH: "volto-form-block"
-  VOLTO_VERSION: "17.0.0"
+  VOLTO_VERSION: "16.30.0"
 
 jobs:
 

diff --git a/Makefile b/Makefile
@@ -57,7 +57,7 @@ build-live: ## Build Addon live
 .PHONY: build-addon
 build-addon: ## Build Addon dev
 	@echo "$(GREEN)==> Build Addon development container $(RESET)"
-	${DEV_COMPOSE} build addon-dev
+	${DEV_COMPOSE} build --no-cache addon-dev
 
 .PHONY: start-dev
 start-dev: ## Starts Dev container

diff --git a/acceptance/ci.yml b/acceptance/ci.yml
@@ -1,15 +1,14 @@
-version: "3"
+version: '3'
 
 services:
-
   addon-acceptance:
     build:
       context: ../
       dockerfile: ./dockerfiles/Dockerfile
       args:
-        ADDON_NAME: "${ADDON_NAME}"
-        ADDON_PATH: "${ADDON_PATH}"
-        VOLTO_VERSION: ${VOLTO_VERSION:-17}
+        ADDON_NAME: '${ADDON_NAME}'
+        ADDON_PATH: '${ADDON_PATH}'
+        VOLTO_VERSION: ${VOLTO_VERSION}
     environment:
       RAZZLE_INTERNAL_API_PATH: http://backend-acceptance:55001/plone
       RAZZLE_API_PATH: http://localhost:55001/plone

diff --git a/acceptance/docker-compose.yml b/acceptance/docker-compose.yml
@@ -9,7 +9,7 @@ services:
       args:
         ADDON_NAME: "${ADDON_NAME}"
         ADDON_PATH: "${ADDON_PATH}"
-        VOLTO_VERSION: ${VOLTO_VERSION:-17}
+        VOLTO_VERSION: ${VOLTO_VERSION}
     volumes:
       - ${CURRENT_DIR}:/app/src/addons/${ADDON_PATH}/
     environment:
@@ -32,7 +32,7 @@ services:
       args:
         ADDON_NAME: "${ADDON_NAME}"
         ADDON_PATH: "${ADDON_PATH}"
-        VOLTO_VERSION: ${VOLTO_VERSION:-17}
+        VOLTO_VERSION: ${VOLTO_VERSION}
     environment:
       RAZZLE_INTERNAL_API_PATH: http://backend-acceptance:55001/plone
       RAZZLE_API_PATH: http://localhost:55001/plone

diff --git a/dockerfiles/docker-compose.yml b/dockerfiles/docker-compose.yml
@@ -9,7 +9,7 @@ services:
       args:
         ADDON_NAME: "${ADDON_NAME}"
         ADDON_PATH: "${ADDON_PATH}"
-        VOLTO_VERSION: "${VOLTO_VERSION:-17}"
+        VOLTO_VERSION: "${VOLTO_VERSION}"
     volumes:
       - ${CURRENT_DIR}:/app/src/addons/${ADDON_PATH}/
     environment:
@@ -35,7 +35,7 @@ services:
       args:
         ADDON_NAME: "${ADDON_NAME}"
         ADDON_PATH: "${ADDON_PATH}"
-        VOLTO_VERSION: "${VOLTO_VERSION:-17}"
+        VOLTO_VERSION: "${VOLTO_VERSION}"
     environment:
       RAZZLE_INTERNAL_API_PATH: http://backend:8080/Plone
       RAZZLE_API_PATH: http://localhost:8080/Plone