Fix misleading message for non-admins when no scales are available

news/141.bugfix

@@ -0,0 +1,2 @@
+Fix misleading message for non-administrators when no scales are available
+[laulaz]

src/plone/app/imagecropping/browser/editor.pt

@@ -15,23 +15,34 @@
       >Image Cropping Editor</h1>
 
       <tal:noscales condition="python:not view.show_cropping">
-        <p class="documentDescription"
-           i18n:translate="noscales_message"
-        >
-      There are no scales to crop. Make sure to add them to the
-          <a href="#"
-             tal:define="
-               portal context/@@plone_portal_state/portal_url;
-             "
-             tal:attributes="
-               href string:$portal/@@imagecropping-settings;
-             "
-             i18n:name="link"
-             i18n:translate=""
+        <tal:def define="
+                   can_access_settings python:checkPermission('Manage portal', context);
+                 ">
+          <div class="alert alert-warning"
+               tal:condition="can_access_settings"
+               i18n:translate="noscales_message"
           >
-            List of scales with crop support</a>
+      There are no scales to crop. Make sure to add them to the
+            <a href="#"
+               tal:define="
+                 portal context/@@plone_portal_state/portal_url;
+               "
+               tal:attributes="
+                 href string:$portal/@@imagecropping-settings;
+               "
+               i18n:name="link"
+               i18n:translate=""
+            >
+              List of scales with crop support</a>
       in the controlpanel.
-        </p>
+          </div>
+          <div class="alert alert-info"
+               tal:condition="not: can_access_settings"
+               i18n:translate="noscales_short_message"
+          >
+      There are no scales to crop.
+          </div>
+        </tal:def>
       </tal:noscales>
 
       <tal:scales condition="python:view.show_cropping">

src/plone/app/imagecropping/locales/de/LC_MESSAGES/plone.app.imagecropping.po

@@ -196,6 +196,11 @@ msgstr "nicht zugeschnitten"
 msgid "noscales_message"
 msgstr "Derzeit sind keine zuschneidbaren Bildgrößen definiert. Sie können diese unter ${link} hinzufügen."
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr "Derzeit sind keine zuschneidbaren Bildgrößen definiert."
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr "Versatz"

src/plone/app/imagecropping/locales/en/LC_MESSAGES/plone.app.imagecropping.po

@@ -192,6 +192,11 @@ msgstr ""
 msgid "noscales_message"
 msgstr ""
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr ""
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""

src/plone/app/imagecropping/locales/es/LC_MESSAGES/plone.app.imagecropping.po

@@ -194,6 +194,11 @@ msgstr "sin recortar"
 msgid "noscales_message"
 msgstr "No hay escalas para recortar. Asegúrate de añadirlas en ${link} en el panel de control."
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr "No hay escalas para recortar."
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""

src/plone/app/imagecropping/locales/fi/LC_MESSAGES/plone.app.imagecropping.po

@@ -190,6 +190,11 @@ msgstr ""
 msgid "noscales_message"
 msgstr "Sivustolla ei ole määritetty kuvakokoja. Määritä kuvakoot osoitteessa ${link}."
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr "Sivustolla ei ole määritetty kuvakokoja."
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""

src/plone/app/imagecropping/locales/fr/LC_MESSAGES/plone.app.imagecropping.po

@@ -192,6 +192,11 @@ msgstr "non-découpée"
 msgid "noscales_message"
 msgstr "Il n'y a pas d'échelles pour la découpe. Veuillez en ajouter dans la ${link} via le panneau de configuration."
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr "Il n'y a pas d'échelles pour la découpe."
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr "décalage"

src/plone/app/imagecropping/locales/it/LC_MESSAGES/plone.app.imagecropping.po

@@ -193,6 +193,11 @@ msgstr "non ritagliata"
 msgid "noscales_message"
 msgstr "Non ci sono miniature da ritagliare. Controlla di averne aggiunte mediante il ${link} nel pannello di controllo."
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr "Non ci sono miniature da ritagliare."
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""

src/plone/app/imagecropping/locales/nl/LC_MESSAGES/plone.app.imagecropping.po

@@ -195,6 +195,11 @@ msgstr ""
 msgid "noscales_message"
 msgstr "Er zijn geen schalen om bij te snijden. Voeg ze toe aan  de ${link} in het controlepaneel."
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr "Er zijn geen schalen om bij te snijden."
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""

src/plone/app/imagecropping/locales/plone.app.imagecropping.pot

@@ -193,6 +193,11 @@ msgstr ""
 msgid "noscales_message"
 msgstr ""
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr ""
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""

src/plone/app/imagecropping/locales/pt_BR/LC_MESSAGES/plone.app.imagecropping.po

@@ -192,6 +192,11 @@ msgstr ""
 msgid "noscales_message"
 msgstr ""
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr ""
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""

src/plone/app/imagecropping/locales/ru/LC_MESSAGES/plone.app.imagecropping.po

@@ -191,6 +191,11 @@ msgstr ""
 msgid "noscales_message"
 msgstr ""
 
+#. Default: "There are no scales to crop."
+#: ../browser/editor.pt:39
+msgid "noscales_short_message"
+msgstr ""
+
 #: ../browser/editor.pt:170
 msgid "offset"
 msgstr ""