Update catalog metadata when removing cropping info #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrTango
approved these changes
Oct 7, 2023
laulaz
reviewed
Oct 9, 2023
Comment on lines
+39
to
+44
| if height >= 65536: | ||
| # special case for "flexible height" settings: | ||
| # we calculate the height with the box ratio | ||
| box_width = self.box[2] - self.box[0] | ||
| box_height = self.box[3] - self.box[1] | ||
| height = int(round(width / box_width * box_height)) |
There was a problem hiding this comment.
@petschki why is that code in this unrelated PR ?
If you confirm it is just an omission on master, I merge this, no problem 👍
There was a problem hiding this comment.
Sorry, I was working on this too on Saturdays sprint and so the title of the PR is a bit missleading. This is needed in order to scale down correctly when cropping the "flexible height" scale. Otherwise It ended up in square scaled image always.
In general I'm not really happy with this hardcoded pixel value, but it works for the new OOTB image scales though. If one creates a custom scale with "100x65000" she/he might get messed 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Somehow I could not do this via
CroppingInfoRemovedEventbecause this didn't get fired. In addition, the event gets fired when changing the cropping information too, so the object had been reindexed twice...