Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property sheet ID is the user ID instead of the plugin ID #95

Closed
reinhardt opened this issue Feb 10, 2020 · 1 comment · Fixed by #96
Closed

Property sheet ID is the user ID instead of the plugin ID #95

reinhardt opened this issue Feb 10, 2020 · 1 comment · Fixed by #96
Assignees

Comments

@reinhardt
Copy link
Contributor

The ID of an LDAPUserPropertySheet instance is the same as the ID of the user it is referring to, not the ID of the plugin as in the plone.app.ldap stack.

https://github.com/collective/pas.plugins.ldap/blob/master/src/pas/plugins/ldap/sheet.py#L50

Is there a reason for this? It would be nice to have it the same. We're checking the sheet ID in a property sync method we use in Quaive.

@reinhardt reinhardt assigned jensens and reinhardt and unassigned jensens Feb 10, 2020
@reinhardt
Copy link
Contributor Author

The docstring for IPropertySheet.getId() says

Identify the sheet within a collection.

See https://github.com/zopefoundation/Products.PluggableAuthService/blob/master/Products/PluggableAuthService/interfaces/propertysheets.py#L32

Returning the user ID does not do that because all sheets in the collection belong to this user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants