Support for override output directory per repository #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebrehault @tiberiuichim could you please take a look? |
README.md
Outdated
| @@ -154,6 +154,7 @@ Properties: | |||
| - `branch`: Optional. Branch name, defaults to the remote's default branch. Ignored if `tag` is defined. | |||
| - `tag`: Optional. Tag name. | |||
| - `develop`: Optional. Boolean, can be toggled on/off to activate/deactivate a package. If activated, then deactivated afterwards, the package gets removed from `jsconfig` maintaining the synchronization with `mrs.developer.json`. Default is `true`. | |||
| - `output`: Optional. Output directory override per repository. It also removes the `src/` prefix. If you still want it, you have to pass it along with the new output. | |||
There was a problem hiding this comment.
"It also removes the src prefix" is not very clear what it's meant. Maybe an example configuration would help, as part of the example in the upper part of this file.
tiberiuichim
approved these changes
Mar 11, 2024
|
@ebrehault can you release it? I can do it myself too, but don't know about the flow in this repo. Can I add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use
mrs-developerto "populate" Volto core monorepo packages folders.So you can do:
missdev --no-config --fetch-https{ "volto-light-theme": { "output": "addons", "package": "@kitconcept/volto-light-theme", "url": "git@github.com:kitconcept/volto-light-theme.git", "https": "https://github.com/kitconcept/volto-light-theme.git" } }And also open the door to have projects as monorepos:
{ "core": { "output": "./", "package": "@plone/volto", "url": "git@github.com:plone/volto.git", "https": "https://github.com/plone/volto.git" }, "volto-light-theme": { "output": "addons", "package": "@kitconcept/volto-light-theme", "url": "git@github.com:kitconcept/volto-light-theme.git", "https": "https://github.com/kitconcept/volto-light-theme.git" } }Although then we need to alter internal Volto dependencies too, might be
mrs-developerthe one to do it, or an script, we'll see.