Disabled packages aware #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not in the config, putting it
… config, instead of leaving them in the config.
ebrehault
reviewed
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development is usual to switch on/off development packages (using
developproperty). However, it used to be a PITA since you had to explicitly manually remove the package fromjsconfig/tsconfigand it was proven to be quite error prone (especially in CI).I added a filter before writing the file that goes through all the config and checks if a explicitly disabled package is still present in the config and removes it if so.
Could be that I cannot see some of the implications or use cases, so please think about if it works for all your workflows.