Improve rtd pull request preview git diff #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and use globbing for `.rst` files
Pull Request Test Coverage Report for Build 9770209385Details
💛 - Coveralls |
…e are changes in the docs
Pull Request Test Coverage Report for Build 9770341770Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9770352781Details
💛 - Coveralls |
|
A link to a preview build will not show up in this PR, but will in future PRs. |
Pull Request Test Coverage Report for Build 9772285057Details
💛 - Coveralls |
|
I should note that the link appears in the PR description if and only if there are changed docs when the PR is opened, and not on subsequent pushes to the PR. See readthedocs/actions#41 |
|
Cool! A link shows up in the test status already: |
| @@ -24,7 +24,7 @@ build: | |||
| # If there are no changes (git diff exits with 0) we force the command to return with 183. | |||
| # This is a special exit code on Read the Docs that will cancel the build immediately. | |||
| - | | |||
| if [ "$READTHEDOCS_VERSION_TYPE" = "external" ] && git diff --quiet origin/main -- docs/ src/icalender/*.py CHANGES.rst CONTRIBUTING.rst LICENSE.rst README.rst .readthedocs.yaml requirements_docs.txt; | |||
| if [ "$READTHEDOCS_VERSION_TYPE" = "external" ] && git diff --quiet origin/main -- . docs/ src/icalendar/*.py *.rst .readthedocs.yaml requirements_docs.txt ':!src/icalendar/fuzzing' ':!src/icalendar/tests' ':!src/icalendar/timezone'; | |||
There was a problem hiding this comment.
if you diff ., then this is for everything... Ah and I see the exclude... cool. I did not know that was possible. ❤️ I learned something!
There was a problem hiding this comment.
Without the ., nothing would be included. There may be other improvements, but this is what worked for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.