Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version of icalendar during install to major version #660

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niccokunzmann
Copy link
Member

See #630 (comment)

This prevents us to wonder about the next major version change and if people get confused.

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9661444419

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.652%

Totals Coverage Status
Change from base Build 9660364734: 0.0%
Covered Lines: 3036
Relevant Lines: 3109

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9661488521

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.652%

Totals Coverage Status
Change from base Build 9660364734: 0.0%
Covered Lines: 3036
Relevant Lines: 3109

💛 - Coveralls

@niccokunzmann niccokunzmann mentioned this pull request Jun 25, 2024
12 tasks
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you release 6.x, this will not be necessary, as pip install will install the latest stable release. Changing it now is premature and harmful.

@niccokunzmann
Copy link
Member Author

When you release 6.x, this will not be necessary, as pip install will install the latest stable release.

It will be useful after the 6.0.0 release so that we can upgrade to version 7 with people being conscious about the version they fix to.

Changing it now is premature and harmful.

I agree, let's wait until a 6.* release is made that is not alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants