Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_broken property #646

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Remove is_broken property #646

merged 2 commits into from
Jun 23, 2024

Conversation

niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Jun 22, 2024 •
edited
Loading

Fix #424
Contribute to #630.

.errors would be enough.

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9627244763

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 97.224%
Totals Coverage Status
Change from base Build 9626822147: -0.004%
Covered Lines: 3082
Relevant Lines: 3170
💛 - Coveralls

stevepiercy
stevepiercy approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge when it passes CI.

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9628142970

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 97.608%
Totals Coverage Status
Change from base Build 9628132228: -0.07%
Covered Lines: 3061
Relevant Lines: 3136
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9628142970

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 97.672%
Totals Coverage Status
Change from base Build 9628132228: -0.004%
Covered Lines: 3063
Relevant Lines: 3136
💛 - Coveralls

@niccokunzmann niccokunzmann merged commit e27ee68 into collective:main Jun 23, 2024
13 checks passed
@niccokunzmann niccokunzmann deleted the is-broken branch June 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove is_broken .attribute for .errors attribute
3 participants
@niccokunzmann @coveralls @stevepiercy