New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all references of RFC 2445 to RFC 5545 #640

Merged

stevepiercy merged 2 commits into collective:main from niccokunzmann:issue-278

Jun 22, 2024

Member

niccokunzmann commented Jun 21, 2024

This fixes #278.


          Rename all references of RFC 2445 to RFC 5545

fb81a2e

coveralls commented Jun 21, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9617609803

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.228%

Totals
Change from base Build 9617195591:	0.0%
Covered Lines:	3087
Relevant Lines:	3175

💛 - Coveralls


          log changes

06735f7

coveralls commented Jun 21, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9617807970

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.228%

Totals
Change from base Build 9617195591:	0.0%
Covered Lines:	3087
Relevant Lines:	3175

💛 - Coveralls

stevepiercy approved these changes

View reviewed changes

Member

stevepiercy left a comment

LGTM, but just one question. If that one instance should remain, then this is good to merge as is.

CHANGES.rst Show resolved Hide resolved

Member Author

niccokunzmann commented Jun 22, 2024 via email

For me, this is part of the changelog and a true statement about the past so it does not need changing.

stevepiercy merged commit 9424f17 into collective:main

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment