Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow docs to build on Python 3.12 by replacing pkg_resources with … #636

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Allow docs to build on Python 3.12 by replacing pkg_resources with … #636

merged 3 commits into from
Jun 21, 2024

Conversation

stevepiercy
Copy link
Member

…importlib.metadata.

  • Fix underline length in README.rst

See #635

@stevepiercy
Allow docs to build on Python 3.12 by replacing pkg_resources with …
c226aeb 
…`importlib.metadata`.

- Fix underline length in README.rst
@stevepiercy stevepiercy self-assigned this Jun 21, 2024
@stevepiercy stevepiercy mentioned this pull request Jun 21, 2024
Open
2 tasks
@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9606195046

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.228%
Totals Coverage Status
Change from base Build 9598258374: 0.0%
Covered Lines: 3087
Relevant Lines: 3175
💛 - Coveralls

@stevepiercy
Copy link
Member Author

@niccokunzmann I'm not sure where to put my change log entry. Please correct me if I put it in the wrong place. Thank you!

@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9606258049

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.228%
Totals Coverage Status
Change from base Build 9598258374: 0.0%
Covered Lines: 3087
Relevant Lines: 3175
💛 - Coveralls

stevepiercy added a commit that referenced this pull request Jun 21, 2024
@stevepiercy
Add missing public classes and functions to API documentation
c24f364 
- Fix docstring underline mismatch error

Fixes #631.
Might depend on #636?
@stevepiercy stevepiercy mentioned this pull request Jun 21, 2024
Merged
niccokunzmann
niccokunzmann approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@niccokunzmann niccokunzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move it over but it can also be moved later.

CHANGES.rst
@@ -31,6 +31,9 @@ Breaking changes:
import icalendar
icalendar.use_pytz()

- Replaced ``pkg_resources.get_distribution`` with ``importlib.metadata`` in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this under Minor changes:

@niccokunzmann niccokunzmann merged commit f2a882c into main Jun 21, 2024
13 checks passed
@niccokunzmann niccokunzmann deleted the 635-docs-build-on-py12 branch September 3, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niccokunzmann niccokunzmann niccokunzmann approved these changes

Assignees

@stevepiercy stevepiercy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevepiercy @coveralls @niccokunzmann