drop python<=3.7 support #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://endoflife.date/python python 3.7 has been EOSed 27 Jun 2023. Filter all code over `pyupgracde --py38-plus`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Pull Request Test Coverage Report for Build 9600575936Details
💛 - Coveralls |
Mostly ruff drops unused imports. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Pull Request Test Coverage Report for Build 9600600563Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9600575936Details
💛 - Coveralls |
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Pull Request Test Coverage Report for Build 9600659732Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9600685185Details
💛 - Coveralls |
stevepiercy
requested changes
Jun 20, 2024
There was a problem hiding this comment.
I don't think this is correct. icalendar v6 supports both timezone implementations pytz and zoneinfo and it will continue to support Python 3.7. This will allow an upgrade path for those stuck on old Pythons.
Some of the other changes in this PR could be useful, if Python 3.7 supports it.
Pull Request Test Coverage Report for Build 9615372085Details
💛 - Coveralls |
niccokunzmann
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Hi! Thanks for using this tool to update the codebase! It is really useful!
I added a few points that would be hard to find.
I wonder why the tests break in that place. It is unusual to have this inconsistent. I added my idea of why.
What do you think? How would you like to proceed? Thanks again for taking this up!
| - ["3.8", "py38"] | ||
| - ["3.9", "py39"] | ||
| - ["3.10", "py310"] | ||
| - ["pypy-3.9", "pypy3"] | ||
| - ["3.10", "docs"] | ||
| - ["3.11", "py311"] | ||
| - ["3.12", "py312"] |
|
Thanks! If you could...
|
|
I wonder why py39 fails... I will have a look. |
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Pull Request Test Coverage Report for Build 9627287775Details
💛 - Coveralls |
|
I've corrected last commit from "<= 3.9" to "< 3.9". |
|
@kloczek Thanks for creating this PR! I am planning on releasing v6 and including this PR in it. So, I hope we can get this merged. 🚀 |
|
The only changes I would request are these:
|
stevepiercy
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Wait for #647 to be merged. Then update CHANGES.rst. See #647 (review)
|
As I;ve mentioned as globally it is declared to exit with error on any try to build on python < 3.8 it is not possible pass that rule on generate .whl archive where are placed install time dependencies. Metadata-Version: 2.1
Name: icalendar
Version: 5.0.13
Summary: iCalendar parser/generator
Home-page: https://github.com/collective/icalendar
Author: Plone Foundation
Author-email: plone-developers@lists.sourceforge.net
License: BSD-2-Clause
Keywords: calendar calendaring ical icalendar event todo journal recurring
Classifier: Development Status :: 5 - Production/Stable
Classifier: Intended Audience :: Developers
Classifier: License :: OSI Approved :: BSD License
Classifier: Operating System :: OS Independent
Classifier: Programming Language :: Python :: 3.8
Classifier: Programming Language :: Python :: 3.9
Classifier: Programming Language :: Python :: 3.10
Classifier: Programming Language :: Python :: 3.11
Classifier: Programming Language :: Python :: 3.12
Classifier: Programming Language :: Python :: Implementation :: CPython
Classifier: Programming Language :: Python :: Implementation :: PyPy
Requires-Python: >=3.8 <<<<<<<<==== HERE.
License-File: LICENSE.rst
Requires-Dist: python-dateutil
Requires-Dist: pytz <<<<<<<===== AAND HERE
Requires-Dist: backports.zoneinfo ; python_version < "3.9" <<== AND HERE
Provides-Extra: test |
|
Cool, yes. That is alright. If you address these two concerns, I would merge it:
|
|
Thanks @kloczek for your contribution! |
|
Thank you 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://endoflife.date/python python 3.7 has been EOSed 27 Jun 2023.
Filter all code over
pyupgracde --py38-plus.