Update license #590
Merged
Update license #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSD is ambiguous. There are several BSD versions and flavours out there (see https://spdx.org/licenses/). Based on the `LICENSE.rst` I think it is "BSD 2-Clause "Simplified" License".
Pull Request Test Coverage Report for Build 7643023145
💛 - Coveralls |
|
Hi, we use the heading here. Isn't the first commit enough? |
|
Not sure if this really deserves an Changelog entry, does it? |
|
|
No need for an entry in the changelog. I'm not against removing the heading if it means that the license is properly detected |
Could you remove the second one then? Let's not change more than necessary :) |
Pull Request Test Coverage Report for Build 7643123501
💛 - Coveralls |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
my dependencyscanner is unfortunately not able to detect your license. I guess others aren't able to detect this too so perhaps you could help us out here?
Not sure about the second commit with the license file. Not sure if you use this heading anywhere but the library github uses to detect the license of a repo now detects it with 100% accuracy...
Thank you for your work...
Max