Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more instrumentation + caught one more exception #584

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

ennamarie19
Copy link
Collaborator

Another quick PR, I added another defined exception that was holding up fuzzer progress and made a tweak to see if we can get more intelligent instrumentation and coverage exploration.

A suggestion would be collecting all raised exceptions under a common base-class, such as CalendarException, so the fuzzer can just do except CalendarException as opposed to string-matching multiple ValueErrors. This would also help users of the library in their error-handling, as well.

@niccokunzmann
Copy link
Member

A suggestion would be collecting all raised exceptions under a common base-class, such as CalendarException, so the fuzzer can just do except CalendarException as opposed to string-matching multiple ValueErrors. This would also help users of the library in their error-handling, as well.

tht sounds good, I would keep the base classes and put them all into exceptions.py

@niccokunzmann niccokunzmann merged commit ce0de32 into collective:master Nov 12, 2023
13 checks passed
@niccokunzmann
Copy link
Member

you already created fixes. feel free to follow the release process to release a new version

@capuanob
Copy link
Contributor

you already created fixes. feel free to follow the release process to release a new version

Good morning,

Could you explain what you mean? Are you asking us to bump the version number due to this PR?

Thank you!

@niccokunzmann
Copy link
Member

I think, there were some fixes made in other PRs.

Independent of this: If you like to release a new version, you can follow the release process: https://icalendar.readthedocs.io/en/latest/maintenance.html - solely as information, to give you a choice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants