Add fixes for OSS-Fuzz bugs and test cases #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p.py derived from OSSFuzz bugs
reproduce fuzzing error
|
Please merge this in first, as it should resolve pipeline errors in the other branch |
|
|
||
| def test_vdd_list_type_mismatch(): | ||
| """If we pass in a string type, we expect it to be converted to bytes""" | ||
| vddd_list = vDDDLists([time(hour=6, minute=6, second=6)]) |
There was a problem hiding this comment.
I am wondering. to_ical() - should it always return a string or bytes? I would assume bytes. Since the library might not have had a refactoring work since Python2.7, I can understand if these get muddled up. I think, we read calendars from bytes... Let's check. I think, this is a quick fix but in the end, we might want to create type annotations and have a common interface. This might be worth creating an issue. I wonder what the other maintainers think.
There was a problem hiding this comment.
Thanks for pointing that in consistency out!
niccokunzmann
merged commit 11eb89b
into
collective:feat/improve-fuzzing-harness
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the fixes to address two bugs discovered by OSS Fuzz and adds two test cases to ensure that they are not reintroduced down the line.
The bugs are as follows: