Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS-Fuzz Integration #569

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

ennamarie19
Copy link
Collaborator

Hello,
This is a follow-on from my Issue regarding OSS-Fuzz integration. This PR introduces the source for the fuzzer and a YAML config to fuzz each PR for a set duration. I would greatly appreciate it being merged in!

I will continue monitoring OSS-Fuzz for bugs and fix any I can in future PRs. Max M also has access to the OSS-Fuzz dashboard to review any security-relevant crashes that may come up.

Please let me know if anything else is needed.

Thank you!

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@niccokunzmann
Copy link
Member

niccokunzmann commented Oct 12, 2023

Hi, thanks for the PR. To merge it I would like the tests to run. E.g. can you create a changelog entry? I wonder why the other tests fail.

@niccokunzmann
Copy link
Member

The other tests fail with

 import atheris
E   ModuleNotFoundError: No module named 'atheris'

It might be needed to either install the dependency or exclude the fuzzing test file from being collected when we test the documentation. Either is fine.

@ennamarie19
Copy link
Collaborator Author

@niccokunzmann Hey Nicco, I added a changelog entry and omitted the fuzzing directory from the doctest!

Thank you!

@niccokunzmann
Copy link
Member

niccokunzmann commented Oct 20, 2023

Thanks! I am a bit confused not seeing the other tests run also. This might not be your code though... I am investigating...

#571
Sorry for that! I will not likely not merge anything before that issue is fixed as I want to be sure that the tests run... It is a small fix though, it seems.

@niccokunzmann
Copy link
Member

#573 is a follow-up pull request that also does not distribute the fuzzing files.

@jacadzaca jacadzaca merged commit 4e15194 into collective:master Oct 25, 2023
3 checks passed
@ennamarie19
Copy link
Collaborator Author

ennamarie19 commented Oct 26, 2023 via email

@ennamarie19
Copy link
Collaborator Author

ennamarie19 commented Oct 26, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants