Add some __eq__ #568
Merged
Add some __eq__ #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed as 088eea7 adds comparison of elements this makes sure that they are compared by value instead of by reference.
|
Hi, thanks for this! Would you like to add unit tests. too? |
|
I think, it would be good to open an issue to discuss value based equality everywhere. |
Closed
|
This is live in v5.0.11. Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed as 088eea7 adds comparison of elements this makes sure that they
are compared by value instead of by reference.
This party fixes niccokunzmann/x-wr-timezone#8. I
think the unit tests should be moved here as well.