Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component._encode: merge instead of ignore parameters on natives #559

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Component._encode: merge instead of ignore parameters on natives #559

merged 5 commits into from
Sep 24, 2023

Commits on Sep 24, 2023

  1. Component._encode: convert to staticmethod 

    - did not reference self at all
- keeps compatibility with existing code
- makes testing easier

Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
    @Zocker1999NET
    Zocker1999NET committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    0111be3 View commit details
    Browse the repository at this point in the history

  2. add test cases for Component._encoding concerning collective#557 

    Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
    @Zocker1999NET
    Zocker1999NET committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    392deb6 View commit details
    Browse the repository at this point in the history

  3. Component._encoding: only skip factory for natives 

    Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
    @Zocker1999NET
    Zocker1999NET committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    61ed4d7 View commit details
    Browse the repository at this point in the history

  4. Component._encode: merge parameters 

    Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
    @Zocker1999NET
    Zocker1999NET committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    07f3c53 View commit details
    Browse the repository at this point in the history

  5. add changelog entry & credits for fixing collective#557

    @Zocker1999NET
    Zocker1999NET committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    4042ba8 View commit details
    Browse the repository at this point in the history