4.x branch: Fix for issue 518 (to_ical() with RRULE BYDAY values>=10) #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ical()): updated WEEKDAY_RULE regex to accept 2 digits. Added tests for to_ical() covering various BYDAY values.
|
Looking at the test logs, failures seem to be py35, py36, pypy3 because the version of Python wasn't available. Other tests were canceled. FWIW, I initially tested with Python 3.9.16 (x64) (pytest & unittest versions) . After the automatic test failures, I tested on Python 2.7.18 (x86) and Python 3.5.3 (Arm64) (both unittest only). All these tests passed. |
|
Hm. The old Python version numbers have changed. Would you be willing to adjust them in the file? This way, the tests suit can run. Otherwise, all following changes might fail, too. Thanks so much for backporting! |
|
#529 includes this commit to merge it with CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 518 fix for the 4.x branch (already fixed in master branch). Issue: #518
The fix itself is the same as in the master branch. The test code has been adapted because the corresponding test code in 4.x uses the unittest module, rather than pytest as in the master branch.
All tests pass (run with setup.py test). Without the fix, the new tests give 3 failures.
Justification for inclusion in 4.x branch: It's a crashing bug. The fix is low risk (never say zero risk!).