Skip to content

Commit

Permalink
Make coverage report optional in case it fails to submit (#664)
Browse files Browse the repository at this point in the history
* Make coverage report optional in case it fails to submit

Sometimes, we get this error:
coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs

This PR allows the error to happen while also maintaining the test
result and making sure that we actually installed all dependencies.

This is a follow up from
#644
main branch failed:
https://github.com/collective/icalendar/actions/runs/9663149658/job/26654629821

* log changes

* use github service for coverage

* Finalize coverage even if tests failed

---------

Co-authored-by: Steve Piercy <web@stevepiercy.com>
  • Loading branch information
niccokunzmann and stevepiercy committed Jul 1, 2024
1 parent 1996b0b commit 4e218ed
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- name: Test
run: tox -e ${{ matrix.config[1] }}
- name: Upload coverage data to coveralls.io
run: coveralls --service=github-actions
run: coveralls --service=github || which coveralls
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_REPO_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Expand All @@ -60,13 +60,16 @@ jobs:
# see https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support
name: Submit test coverage
needs: run-tests
# always finalize coverage aftest tests ran
# see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-not-requiring-successful-dependent-jobs
if: ${{ always() }}
runs-on: ubuntu-latest
container: python:3-slim
steps:
- name: Install dependencies
run: pip3 install --upgrade coveralls
- name: Upload coverage
run: coveralls --service=github-actions --finish
run: coveralls --service=github --finish || which coveralls
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_REPO_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Expand Down
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Minor changes:

- Test that all code works with both ``pytz`` and ``zoneinfo``.
- Make coverage report submission optional for pull requests
- Parallelize coverage
- Rename ``master`` branch to ``main``, see `Issue
<https://github.com/collective/icalendar/issues/627>`_
- Added missing public classes and functions to API documentation.
Expand Down

0 comments on commit 4e218ed

Please sign in to comment.