Email otp #48
Merged
Email otp #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamico
reviewed
Apr 11, 2024
|
|
||
| manager = getUtility(IKeyManager) | ||
|
|
||
| return md5((uid + email + manager.secret()).encode()).hexdigest()[:10] |
There was a problem hiding this comment.
md5 is not OTP although the secret rotates periodically (can't tell you with what timing/logic), you have to enter a form of expiration. You can directly use https://github.com/pyauth/pyotp?tab=readme-ov-file#time-based-otps using as secret the data you used here, and change the validation from "==" to totp.verify
Otherwise everything is ok for me.
There was a problem hiding this comment.
Si, infatti stavo pensado che il secret cambia, in caso si può anche aggiungere nel hash il datetime slottato per 15 min for example
mamico
approved these changes
Apr 11, 2024
cekk
requested changes
Apr 11, 2024
src/collective/volto/formsupport/browser/templates/email_confirm_view.pt
Outdated
Show resolved
Hide resolved
src/collective/volto/formsupport/restapi/services/validation/configure.zcml
Outdated
Show resolved
Hide resolved
src/collective/volto/formsupport/restapi/services/validation/email.py
Outdated
Show resolved
Hide resolved
|
Also, fix actions please |
cekk
requested changes
Apr 11, 2024
src/collective/volto/formsupport/restapi/services/validation/configure.zcml
Outdated
Show resolved
Hide resolved
README.rst
Outdated
| @validate-email-token | ||
| --------------------- | ||
|
|
||
| Supposed to validate the OTP code recieved by user via email. |
Pull Request Test Coverage Report for Build 8720476249Details
💛 - Coveralls |
cekk
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.