Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the format of the contents of the email #31

Merged
merged 12 commits into from
May 24, 2023

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Apr 25, 2023

Allow the email that is sent to either be styled as a list (current behaviour) or as a table (new behaviour from this PR).

## Markup of emails

List:

<p>A new form has been submitted from <strong>Form</strong>:</p>
  <ul>
    
      <li>
          <strong>Field 1:</strong> List
      </li>
    
  </ul>

Table:

 <table>
    <caption>Email results for Form</caption>
    <thead>
      <tr role="row">
        <th scope="col" role="columnheader">Field</th>
        <th scope="col" role="columnheader">Value</th>
      </tr>
    </thead>
    <tbody>
      
        <tr role="row">
          <th scope="row" role="rowheader">Field 1</th>
          <td>Table</td>
        </tr>
      
    </tbody>
  </table>

fixes pretagov/nsw-demo#266

@JeffersonBledsoe
Copy link
Member Author

JeffersonBledsoe commented Apr 25, 2023

@cekk I still need to sort out the i18n side of this PR (I've not done PageTemplate i18n before), just wanted to get your thoughts early on 🙂

@JeffersonBledsoe
Copy link
Member Author

@cekk I made a few of the changes you brought up. Not sure if I should update the locales or if that's to be done as part of a release.

@cekk
Copy link
Collaborator

cekk commented May 23, 2023

@cekk I made a few of the changes you brought up. Not sure if I should update the locales or if that's to be done as part of a release.

Yes, feel free to update locales to add new translations.

# Conflicts:
#	src/collective/volto/formsupport/tests/test_send_action_form.py
@JeffersonBledsoe
Copy link
Member Author

JeffersonBledsoe commented May 24, 2023

@cekk Thanks for checking over this again. I've updated the locales now too.

Once this and #24 are merged, any chance of a release?

@cekk
Copy link
Collaborator

cekk commented May 24, 2023

yes, will release with all the changes

@cekk cekk merged commit 7a15276 into collective:main May 24, 2023
@JeffersonBledsoe JeffersonBledsoe deleted the email-contents-format branch May 24, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants