Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sidebar Locking #4

Open
santonelli opened this issue Oct 16, 2018 · 1 comment
Open

Add Sidebar Locking #4

santonelli opened this issue Oct 16, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@santonelli
Copy link
Collaborator

santonelli commented Oct 16, 2018

Summary
As a website user, I want to be able to lock the sidebar, so that it stays opened like a permanent sidebar and I can navigate easily.

Acceptance Criteria

  • It's done when a lock icon is shown on the top outer corner of the sidebar.
  • It's done when a click on the lock icon locks the sidebar to act like a permanent sidebar. This means:
    • It is not closing itself when you click on an item or navigate through the site.
    • The cover (Add Livesearch and Sitemap to Cover #9) is not shown, so you can still see and navigate the content page.
    • The lock icon changes to show the locked state.
  • It's done when an additional click on the locked icon reverts the locked state.
  • It's done when there is a sidebar control panel.
  • It's done when there is an option in the sidebar control panel to set the default state (locked/unlocked, default should be unlocked).
  • It's done when there is an option in the sidebar control panel to remove the locking icon.
  • It's done when the user's lock-state-setting is saved to / restored from cookies.
  • It's done when it is tested and working on desktop and phone.
@santonelli santonelli added the enhancement New feature or request label Oct 16, 2018
@santonelli santonelli modified the milestones: 1.0a1, Future Oct 16, 2018
@Netroxen Netroxen modified the milestones: Future, 1.0.0a3 Jan 11, 2019
@Netroxen Netroxen changed the title Add locking feature Add Sidebar Locking Jan 11, 2019
@Netroxen
Copy link
Collaborator

This feature was intended as a way to ease content editing, initially the sidebar pushed the site content as it was opened, making the locking feature usable.

However, now that the sidebar slides over the page content, locking it doesn't make sense as the user will not be able to edit something hidden by it.

I propose that instead of locking the sidebar, we replace this with an "Edit Mode" which collapses the sidebar down to only showing the icons. As part of this functionality, the sidebar will remain open between views, and not only that, but we can play with some designs to optimize mobile editing...

@Netroxen Netroxen modified the milestones: 1.0.0a3, 1.0.0a4 Jan 17, 2019
@sarn0ld sarn0ld modified the milestones: 1.0.0a4, 1.0.0a5 Feb 4, 2019
@Netroxen Netroxen modified the milestones: 1.0.0a5, 1.0.0a6, 1.0.0a7 Feb 4, 2019
@sarn0ld sarn0ld modified the milestones: 1.0.0a7, 1.0.0.a9 May 8, 2019
@santonelli santonelli removed this from the 1.0.0a9 milestone May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants