Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also update Mimetype, Owner & Workflow of dexterity objects #15

Open
djowett opened this issue Oct 26, 2015 · 2 comments
Open

Also update Mimetype, Owner & Workflow of dexterity objects #15

djowett opened this issue Oct 26, 2015 · 2 comments

Comments

@djowett
Copy link
Contributor

djowett commented Oct 26, 2015

collective.blueprint.jsonmigrator (the precursor of this product) has a PR which fixes the above blueprints so they have the same effect on writing Dexterity items as Archetypes. It seems reasonable to me that we should do this also here in this product.

This basically means replacing:
if IBaseObject.providedBy(obj):
with
if IBaseObject.providedBy(obj) or (dexterity_available and IDexterityContent.providedBy(obj)):
where dexterity_available is set when from plone.dexterity.interfaces import IDexterityContent succeeds.

There is also a code change handling dexterity datafields in the PR mentioned, but as I recall I successfully used the transmogrify.dexterity.schemaupdater blueprint for handling that usecase, so I don't personally recommend that, though opinions may differ. Perhaps we should open a separate Issue to discuss that?

[search for IBaseObject in this product] https://github.com/collective/collective.jsonmigrator/search?utf8=%E2%9C%93&q=IBaseObject

thanks at @idgserpro for spotting that (and @maartenkling for the original PR)

@djowett
Copy link
Contributor Author

djowett commented Oct 28, 2015

Note: it may be that plone.app.transmogrifier.workflowupdater is being used instead of collective.jsonmigrator.workflowhistory in most cases

erral added a commit to erral/collective.jsonmigrator that referenced this issue Nov 11, 2015
erral added a commit to erral/collective.jsonmigrator that referenced this issue Jun 2, 2016
erral added a commit to erral/collective.jsonmigrator that referenced this issue Jun 2, 2016
@jensens
Copy link
Member

jensens commented Jul 9, 2021

I would use the specific interfaces: like IOwned from AccessControl or IMutableDublinCore to have it generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants