Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix actions urls when on action or field traverser #239

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

jensens
Copy link
Member

@jensens jensens commented Aug 17, 2020

URLs in actions menu pointed to form/actions/fields if on form/actions. now fixed.

@jensens jensens added the bug label Aug 17, 2020
@jensens jensens force-pushed the fix-urls branch 2 times, most recently from e77b325 to 44736f3 Compare August 17, 2020 14:15
@jensens jensens merged commit b2d8c53 into master Aug 17, 2020
@jensens jensens deleted the fix-urls branch August 17, 2020 14:35
@mauritsvanrees
Copy link
Member

I think this needs an upgrade step.

Also, I wonder if this has caused Travis test failures. The Travis job for this PR did not finish. Seems a bit unlikely though.
See test failures in this new job today:
https://travis-ci.org/github/collective/collective.easyform/jobs/718885432

I see the tests on the master branch are not run after merging a PR. In the Travis settings, I have now activated 'Build pushed branches'. I guess that was the problem. I have triggered a build.

@mauritsvanrees
Copy link
Member

@jensens Does this PR actually fix anything? I cannot reproduce the problem.
When I use easyform 3.0.1, so the release before this change, and run bootstrap-py3.sh (Python 3.7) and create a site, the urls are fine.

  • I create a form.
  • I go to the Fields action.
  • From there I go to the Actions action
  • Then to the saved data action. (This does not show anything, but you did some fixes for that later.)

I can click around what I like, going to a different action or the same action, it all works.
What does not work is when I manually add a slash at the end of the url, so: actions/. Then the urls are broken, and your fix would help. But the urls don't have slashes at the end.

Did you see this go wrong on a different Plone or Python version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants