Fix error when clearing content chooser input #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we cleared the filter, the contents of the previous filter and the amount of items found were still displayed. This was due to a Javascript error. The variable portal_url was not defined inside the function that is called when clicking on the clear button. Then we use this.portal_url, to use the class variable. For this to be considered the class, it was necessary to use arrow functions.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #944 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 49 49
Lines 2913 2913
=======================================
Hits 2705 2705
Misses 208 208 Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we cleared the filter, the contents of the previous filter and the amount of items found were still displayed.
This was due to a Javascript error. The variable
portal_urlwas not defined inside the function that is called when clicking on the clear button. Then we usethis.portal_url, to use the class variable. Forthisto be considered the class, it was necessary to use arrow functions.Fixes #942