fix issue #871 and #859

[Mubra]

closes #871 , by using a variable referring to the selected object through the "on" event

This same closes #859 using the same method

I am waiting for comments to add this to the file "CHANGES.rst"

[idgserpro]

@Mubra thanks for the PR! Please add closes #xxx on description.

[Mubra]

hi @idgserpro I opened a topic:
https://community.plone.org/t/error-in-travis-when-correcting-errors-in-collective-cover/10389

To see if this helps solve problems with "travis"

[idgserpro]

Tests are failing. I can now see that there is no error in the console when resizing the column. Please try adding tests for column resizing.

[idgserpro]

Please add entries in changes.

[idgserpro]

@Mubra we already have column delete testing. See:

collective.cover/src/collective/cover/tests/test_layout.robot

Lines 62 to 65 in 3f3bbbd

	Delete a Column in the First Row
	Delete the First Row
	Count Number of Columns 3

This test is really failing but it doesn't make the build fail because this is tagged with Mandelbug:

collective.cover/src/collective/cover/tests/test_layout.robot

Line 17 in 3f3bbbd

[Tags] Mandelbug

This was done by @hvelarde on 3f3bbbd

I think this tag can be removed as it's hide an error.

[Mubra]

Thank you @idgserpro very much for the comment, I will work on this test to make it happen, and to be able to add the corresponding change in this "PR", I only comment that the tests work in my local environment, I thank you for your support and comments. Working ...

[Mubra]

This is the error I say, I just ran just "test_layout.robot" and it runs perfectly, this errorr, is the one that commented that is fixed with the comments in "Plone Community"

[Mubra]

Ready 🔨 @idgserpro

[idgserpro]

@Mubra please, make rebase with master to see how the tests behave.

Also remove the Mandelbug tag from test_layout.robot to see if this PR fix this test.

Try adding tests for column resizing.

[Mubra]

Hi @idgserpro I do not know what you mean by "make rebase with master" and add a test that works correctly where apart from the resize, I try in general a "fast" functionality

[idgserpro]

@Mubra make rebase is basically bringing master commits to your branch. Take a look here.

You will basically have do:

cd collective.cover
git checkout fix_issue_871
git fetch origin
git rebase origin/master
git push -f

If there is conflict, you'll need to resolve.

[Mubra]

good night @idgserpro , the errors marked in travis, are alien to my changes, download a clean installation of collective (master) run the tests and indeed, the tests work now without the need of the environment variables I used before, but the following errors
[error one ](https://travis-ci.org/collective/collective.cover/jobs/602961639#L1763
[error two ](https://travis-ci.org/collective/collective.cover/jobs/602961639#L1776
They show up without my changes,
adding my test "test_layour_resize.robot" in the same installation, it does not generate errors, here my log:

[idgserpro]

They show up without my changes,
adding my test "test_layour_resize.robot" in the same installation, it does not generate errors, here my log:

The strange thing's that your test failed all Travis jobs. This doesn't seem to be a Mandelbug. If the tests didn't fail locally, it could be a firefox version difference. However, as I said in the comments above, you don't have to do this test here.

[idgserpro]

Now we can see that this PR fix the row/column delete test. However, the Mandelbug continues. I'am on favor of removing the Mandelbug tag. The test caught the error but no one see it because of the Mandelbug tag. See #873 (comment) . When we are in a hurry, we only check if the job is green. We have the option to restart the job on error.

@hvelarde @rodfersou opinions?

[Mubra]

Hello @idgserpro , I am very sorry for the time, but retaking this case, the errors shown in the travis log, I can not replicate them, I do not know if maybe they changed the settings or the resolution in which the tests are executed this errorr,

[idgserpro]

@Mubra see my comments above. You don't have to repeat all the test_layout.robot code here. You can remove the lines after 28. Then you need to check if resize worked.

[Mubra]

@idgserpro Good day.

[idgserpro]

@Mubra can you please fix coveralls error? See:

collective/sc.social.like@c3e591f

[Mubra]

@Mubra can you please fix coveralls error? See:

collective/sc.social.like@c3e591f

ok, i check it

[hvelarde]

@idgserpro that's a different issue (#877) that must be addressed on another PR.