Use webpack #826
Use webpack #826
Conversation
rodfersou
force-pushed
the
use-webpack
branch
3 times, most recently
from
8eecde8
to
fd03582
Compare
|
Issues that may be able to be closed when this PR is merged:
|
rodfersou
force-pushed
the
use-webpack
branch
4 times, most recently
from
29f6753
to
880b136
Compare
|
I run into this issue in our webpack recipe collective/sc.recipe.staticresources#44 IIRC already found one method to fix it, but don't remember in what project used it; also don't have a glue on what is the better solution for this.. Can someone help me find how to fix this? |
rodfersou
force-pushed
the
use-webpack
branch
from
5e463ff
to
dcc23f8
Compare
|
@rodfersou just add another icon for it. |
rodfersou
force-pushed
the
use-webpack
branch
3 times, most recently
from
94b2ca7
to
685afdc
Compare
|
At this point the code from this PR is working, just need to fine tune everything to merge. |
rodfersou
force-pushed
the
use-webpack
branch
from
73eb1e5
to
66537a3
Compare
|
@hvelarde I have a problem here, RF tests don't run locally for this package; it just open the firefox and freeze without navigate to any page... after wait a little gives a timeout. |
|
@rodfersou check if the selenium package is the same. |
|
@idgserpro yes, it is.. |
|
Maybe now it is better to don't touch bootstrap |
rodfersou
force-pushed
the
use-webpack
branch
4 times, most recently
from
ffc0465
to
d2b0776
Compare
|
@hvelarde green |
|
@agnogueira @claytonc @idgserpro this seems to be ready, do you mind to help me with a quick review? |
| @@ -26,14 +27,10 @@ eggs = z3c.checkversions [buildout] | |||
| recipe = plone.recipe.codeanalysis[recommended] | |||
| directory = ${buildout:directory}/src/collective/cover | |||
| clean-lines = True | |||
| clean-lines-exclude = ${buildout:directory}/src/collective/cover/static/js/vendor/ | |||
| csslint = True | |||
There was a problem hiding this comment.
Can't check be done in the webpack folder?
There was a problem hiding this comment.
IMO, it doesn't make sense to run the linters on code generated by webpack.
| debug-statements = True | ||
| flake8-ignore = B901,D001,E501,P001,T000 | ||
| flake8-max-complexity = 12 | ||
| jshint = True |
There was a problem hiding this comment.
Can't check be done in the webpack folder?
There was a problem hiding this comment.
IMO, it doesn't make sense to run the linters on code generated by webpack.
|
wow! finally! 👏 |
JS
Remove dependency of collective.bootstrap and add boostrap javascript into webpackCSS
Viewlet
General