Issue 745 fix idatetimewidget if ploneappcontenttypes #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix IDatetimeWidget tile override if using plone.app.contenttypes >= 1.1.1: collective.z3cform.datetimewidget is merged into plone.formwidget.datetime, so the zcml must override the template from plone.formwidget.datetime.z3cform.interfaces.IDatetimeWidget as well. Closes #745.
https://travis-ci.org/collective/collective.cover/builds/269263095 To avoid the errors: AssertionError: Aug 28, 2017 04:33 PM != Aug 28, 2017 04:31 PM AssertionError: Aug 28, 2017 04:36 PM != Aug 28, 2017 04:33 PM AssertionError: Aug 28, 2017 04:33 PM != Aug 28, 2017 04:31 PM Now we compare the length of the dates instead of the date string itself.
idgserpro
force-pushed
the
issue_745_fix_idatetimewidget_if_ploneappcontenttypes
branch
from
63394f8
to
b66f127
Compare
hvelarde
approved these changes
Aug 29, 2017
hvelarde
deleted the
issue_745_fix_idatetimewidget_if_ploneappcontenttypes
branch
|
Would you mind creating a new release so we can focus on finishing IDG 1.2b1? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #745, check the issue for more information. This whole collective.z3cform.datetimewidget and plone.formwidget.datetime dependency situation here can be improved in the future by discussing #747 and deciding the best approach.
If possible, a new release after merge would be a good idea.