Do not declare the Cover class as an implementer of IDAVAware #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes absolutely no sense and is causing an error when doing a GenericSetup export.
idgserpro
reviewed
Apr 18, 2017
There was a problem hiding this comment.
We don't know the impacts of this change, but exporting in portal_setup with plone.dexterity.interfaces.IDexterityContainer as a marker interface and removing IDAVAware they generate the same tar.gz.
And importing the generated tarball in portal_setup after removing IDAVAware it works as well (so, in theory, the motivation for adding this interface for importing content is now gone).
So, feel free to add this modification and close the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes absolutely no sense and is causing an error when doing a GenericSetup export.
fixes #396