Remove dependency on five.grok

[l34marr]

A new pull request based on the latest master branch, hopefully this will make things easier to move on.
I try this manually with a fresh Plone 4.3.10 instance and seems working. However, I run locally bin/test and see errors like:

• AttributeError: 'IncrementalEncoder' object has no attribute '_push'
• AttributeError: 'UpdateTile' object has no attribute 'response'
• AssertionError: Parent suite setup failed: WebDriverException: Message: The browser appears to have exited before we could connect. If you specified a log_file in the FirefoxBinary constructor, check it for details.

I know little about debugging test errors. Advices are appreciated.

[hvelarde]

thanks for taking care of this, @l34marr! seems there are still a few fixes pending to make tests pass.

I have no idea on the first error, but the others seem easy to fix: tests for UpdateTile may need to use self.request.RESPONSE attribute instead of view.request; the other looks like an outdated version of Selenium; run bin/buildout again to update it.

[hvelarde]

use the @implementer decorator instead

[hvelarde]

@rodfersou can you help here?

[rodfersou]

@hvelarde sure

[rodfersou]

Why we use DefaultView instead of BrowserView ?

[hvelarde]

I was wondering the same, but that's what we did in collective.nitf; please do some research about it.

[davilima6]

DefaultView brings in the "w" dictionary, containing Dex fields and widgets. If you don't need that in your template or class, it's best to save the overhead and use a simpler BrowserView. Refs:

• http://docs.plone.org/external/plone.app.dexterity/docs/custom-views.html#display-view
• https://training.plone.org/5/mastering_plone/views_2.html#the-default-view

[rodfersou]

thank you for the explanation

[hvelarde]

this could be moved to __init__()

[hvelarde]

@l34marr @rodfersou the package is in an unusable state now we need to fix all view following the pattern explained in the documentation, not just the tests; for the record:

class MyView(BrowserView):

    def __init__(self, context, request):
        # used to initialize the view code, only add if need
        self.context = context
        self.request = request

    def render(self):
        # used to render the code (JSON, etc.) or just to call the template
        return self.index()

    def __call__(self):
        # use it to do things needed before rendering the code and after the initialization
        return self.render()

[rodfersou]

@hvelarde the documentation is not talking about the __init__ method.. and if it is ommited, it does exactly the same https://github.com/zopefoundation/Zope/blob/master/src/Products/Five/browser/__init__.py#L27-L29

[hvelarde]

and that's exactly what I meant when I wrote: only add if need.

[hvelarde]

@rodfersou wouldn't be better to do '{0}/{1}'.format(tile_type, tile_id) only once?

[rodfersou]

@hvelarde finally green \o/

[hvelarde]

@l34marr @idgserpro we need help on testing nothing is broken now.

[idgserpro]

I tested and everything was ok. Great work!

Remembering that this fix #510.

[l34marr]

@hvelarde I manually test it with a fresh Plone 4.3.9 installation and work well. The buildout message still shows the grok dependency but I believe that's because of plone.directives.form 2.0.2. Thank you all the Plone heroes for the great work.