Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourcecollective.covercontentchooser listed as "potentially suspicious" #750

Closed
djowett opened this issue Aug 29, 2017 · 4 comments · Fixed by #751
Closed

resourcecollective.covercontentchooser listed as "potentially suspicious" #750

djowett opened this issue Aug 29, 2017 · 4 comments · Fixed by #751
Assignees
Labels

Comments

@djowett
Copy link
Contributor

djowett commented Aug 29, 2017

by some scanning software. I know it doesn't know what it's talking about, but could we at least make contentchooser for authenticated only?

It's this line causing alarm:
data:image/vnd.microsoft.icon;base64,AAACAAEAICACAAcABQAwAQAAFgAAACgAAAAgAAAAQAAAAAEAAQAAAAAAAAEAAAA']]

vnd.microsoft.icon is not especially current according to this.... https://stackoverflow.com/a/28300054/3046069

@hvelarde
Copy link
Member

hvelarde commented Aug 29, 2017

I agree; we're quite busy right now and this seems easy to fix… PR anyone? ;-)

@hvelarde
Copy link
Member

hvelarde commented Sep 1, 2017

I'm going to make a quick fix of the MIME type as @idgserpro is waiting for a release; the real fix is refactoring the whole CSS/JS mess.

@idgserpro
Copy link
Member

Thanks @hvelarde! @djowett would you mind creating a new issue to remember to refactor the CSS/JS like @hvelarde said? The PR https://github.com/collective/collective.cover/pull/751/files is going to close this issue.

@djowett
Copy link
Contributor Author

djowett commented Sep 7, 2017

@idgserpro done - IIUYC
Thanks @hvelarde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants