Update to plone meta and Plone6 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9641653198Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9664786896Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9664870998Details
💛 - Coveralls |
* With `3.8` you get an error in GitHub Actions: `Error when evaluating 'strategy' for job 'test'. plone/meta/.github/workflows/test.yml@main (Line: 23, Col: 25): Unexpected value '3.8'` * With `["3.8"]` you get a yaml error running config-package from plone/meta, as it gets spelled like this: `py-versions: '['3.8']'` (Not sure if I have the single or double quotes right.)
Pull Request Test Coverage Report for Build 9682969983Details
💛 - Coveralls |
It fails because the `clamav` daemon is not running. The `ci.yml` file has a few lines of code that we would need to run: ``` sudo apt-get -y install clamav clamav-daemon clamav-freshclam clamav-unofficial-sigs sudo bash -c 'echo -e "TCPSocket 3310\nLocalSocket /tmp/clamd.socket\n$(cat /etc/clamav/clamd.conf)" > /etc/clamav/clamd.conf' sudo freshclam -l /tmp/freshclam.log sudo systemctl start clamav-daemon.service sudo systemctl status clamav-daemon.service head /etc/clamav/clamd.conf ``` For installing extra packages we could use the `os-packages` input, but there is currently no hook in plone/meta for running arbitrary commands.
Pull Request Test Coverage Report for Build 9683188832Details
💛 - Coveralls |
[ci skip]
In the first release (2.0a1) this was already not used, and replaced by registry settings. That release was based on collective.ATClamAV.
Pull Request Test Coverage Report for Build 9683709535Details
💛 - Coveralls |
Calling 'rfbrowser init' in tox takes a long time.
Pull Request Test Coverage Report for Build 9684886378Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9685015189Details
💛 - Coveralls |
mauritsvanrees
approved these changes
Jun 26, 2024
|
I have asked @tisto for PyPI rights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.