Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation/deinstallation and add flag to disable scanning #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tschorr
Copy link
Contributor

@tschorr tschorr commented Apr 14, 2021

This PR

  • Fixes querying the registry for scanner settings. Currently c.clamav will raise an error when trying to upload a file and the add on is not installed
  • Properly removes registry settings in the uninstall profile
  • Adds a flag to enable/disable virus scanning in the configlet

@tschorr tschorr requested a review from tisto April 14, 2021 09:31
@tschorr tschorr changed the title Improve install/uninstall and add flag to disable scanning Improve installation/deinstallation and add flag to disable scanning Apr 14, 2021
@tisto tisto requested a review from andreasma April 14, 2021 12:49
@tisto
Copy link
Member

tisto commented Apr 14, 2021

@andreasma do you want to have a look at this PR? Are you still actively using this add-on?

@tschorr
Copy link
Contributor Author

tschorr commented Apr 27, 2021

@tisto @andreasma ping - could we have a PyPI release?

@tisto
Copy link
Member

tisto commented Apr 27, 2021

@tschorr I am busy with WPD preparations right now. Feel free to ping me again in case I don't look into it in the next days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants