Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save as dialog #97

Closed
ConnectedReasoning opened this issue Oct 22, 2016 · 9 comments
Closed

Save as dialog #97

ConnectedReasoning opened this issue Oct 22, 2016 · 9 comments

Comments

@ConnectedReasoning
Copy link

Description

I don't see any methods to save

Steps to reproduce

navigate to video-only.html record and then stop

Results

dfsdf

Expected

I expect to find information necessary to save video

Actual

There is no documentation about how to save video

Error output

If there are any errors at all, please include them here.

Additional Information

Nothing to add

versions

Current

videojs

The current

browsers

Chrome

OSes

Mac

@thijstriemstra
Copy link
Member

I guess you want to see a link where you can download the recorded video? You can also right-click the video and save it from there.

@thijstriemstra
Copy link
Member

Closing because there's no further feedback.

@clavish
Copy link

clavish commented Nov 24, 2016

I have similar question. How to save video? (not upload to server) When user stops recording then its able to click on button "save to disk". Any ideas? Thank you!

@thijstriemstra
Copy link
Member

@clavish remember it's already saved to disk in a temporary location.

That being said, use this to show a save as dialog when the user finished recording for example:

// user completed recording and stream is available
player.on('finishRecord', function()
{
    player.recorder.engine.engine.save({
        // file extension will be automatically added
        video: 'video-file-name',
        // audio: 'audio-file-name'
    });
});

This is not a really nice API so I'll re-open this ticket and add something better.

@thijstriemstra thijstriemstra changed the title Can you please provide guidance on how to save video and audio in the event handler? Save as dialog Nov 24, 2016
@ConnectedReasoning
Copy link
Author

I extended a sample to offer a download option. I will add to this soon

@clavish
Copy link

clavish commented Nov 24, 2016

@thijstriemstra thank you, works great now 👍

thijstriemstra added a commit that referenced this issue Nov 26, 2016
@thijstriemstra
Copy link
Member

thijstriemstra commented Nov 26, 2016

thanks for the feedback @clavish. In upcoming 1.5.1 it should be as simple as player.recorder.saveAs(nameObj), see https://github.com/collab-project/videojs-record#save-data.

@aleksey-lav
Copy link

and how to saveAs already converted video by ffmpeg ?

@thijstriemstra
Copy link
Member

and how to saveAs already converted video by ffmpeg ?

Please open a new ticket with a specific request.

@collab-project collab-project locked as resolved and limited conversation to collaborators Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants