Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey Added #197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

vaibhavlonari
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vaibhavlonari , Can you please write more about your journey? If you want to know what exactly your journey should include please refer to What should I share in my journey?.

Data.json Outdated Show resolved Hide resolved
@vaibhavlonari
Copy link
Author

Changes are made as you said. Added Journey and changed Data.json . Please review and merge!

Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vaibhavlonari , Can you please write more about your journey? If you want to know what exactly your journey should include please refer to What should I share in my journey?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants