Bugfix/QueryString and Feature/Security #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. querystring -> qs on line 2
…. querystring -> qs on line 2
Feature/cert validations
ssl security is now a feature
Feature/cert validations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue of nested objects in a JSON payload sent through a POST request.
nodejs/node-v0.x-archive#1665
The library "querystring" is replaced with "qs". This packed was already installed via dependancy.
The "qs" package has an export "stringify" so no additional coding was required.
( I got pretty lucky )
I have also added the following to the package.json
"prepare": "npm run build"
I could not get npm to download the forked repository with src files. It expects the download to already be compiled unless the above snippet is attached. GitHub doesn't build the project like npm, so the only other trivial ways to achieve collaborating was to add my fork to npm or remove lib from the .gitignore and commit the folder to github. These two options seemed excessive when compared with the above, so I suggest leaving it in the package. I am not a node expert, so if this is a breaking change then we should possibly just add the process to the documentation.
____________ 2/6/2020
Added security option to disable ssl validation on a per mapping level
Best,
Richard Miles