Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Briefly dependency not shown as required in the README #12

Closed
SylvainBigonneau opened this issue Apr 5, 2019 · 6 comments
Closed

Briefly dependency not shown as required in the README #12

SylvainBigonneau opened this issue Apr 5, 2019 · 6 comments

Comments

@SylvainBigonneau
Copy link

As far as I have checked, I could not start generating a PDF with this module without installing and starting the :briefly dependency, as Briefly.entry is used by Generate.from_string.

Should we add it to the README?

@speeddragon
Copy link
Contributor

I think you shouldn't need to add :briefly to your applications, because since Elixir 1.4 that is done automatically. What elixir version do you use ?

@SylvainBigonneau
Copy link
Author

I think you shouldn't need to add :briefly to your applications, because since Elixir 1.4 that is done automatically. What elixir version do you use ?

# elixir -v
Erlang/OTP 21 [erts-10.2.5] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe]
Elixir 1.8.1 (compiled with Erlang/OTP 21)

@speeddragon
Copy link
Contributor

Do you have applications: or extra_applications: in your mix.exs ? If you have the first one, you need to add :briefly to it, if you have extra_applications, can you provide the error message that appear when you try to generate a PDF ?

@SylvainBigonneau
Copy link
Author

Do you have applications: or extra_applications: in your mix.exs ? If you have the first one, you need to add :briefly to it, if you have extra_applications, can you provide the error message that appear when you try to generate a PDF ?

Ach, yes indeed, I am using applications: ! So I guess it's overwriting the default ones?

@speeddragon
Copy link
Contributor

If you use applications: you will need to add every module that you use to it. You can read more in here. Either way, I can mention that on the README something in line like this. If you want you can open a PR, or I will add it next week.

@SylvainBigonneau
Copy link
Author

SylvainBigonneau commented Apr 5, 2019

Thank you for your explanations, that cleared it up for me. I had already added :briefly to my applications list before opening this issue, and it had fixed my error, but I was in the idea that it was required (and as you seem to be saying it is likely not if using extra_applications instead) so I thought the README was missing that information, hence this issue.

I don't really know how one would make this clearer on the README without overexplaining basic configuration logic, so I won't try a PR for myself. But I would be grateful if you found the words!

Feel free to close this issue from now on :)

speeddragon added a commit that referenced this issue Apr 11, 2019
Update readme to reflect issues #12 and #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants