Use downcase() only for fact sets which fact a valid operatingsystem #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the 1.9 test fails. Pretty sure it's not because of my change. |
|
I've checked out develop branch and runned It must be your change that breaks this test on Ruby 1.9. |
cardil
requested changes
Aug 12, 2019
cardil
reviewed
Aug 12, 2019
facterdb 0.8.1 introduced a SLES 15 SP1 fact set which doesn't have a operatingsystem fact. This is due to bugs in facter 2.5. As facter 2.5 doesn't get maintance anymore, we need to fail safely here. Fixes coi-gov-pl#3.
baurmatt
force-pushed
the
fix/no-operatingsystem
branch
from
c47aa0c
to
bccd5c1
Compare
|
Hey @cardil, thanks for taking a look! :) I've altered the output as suggested and added a test. Regarding the failing tests: I'm pretty sure the error isn't related because the latest commit in the |
|
Hey @cardil could we get this merged and released? :) |
|
Hey @cardil, any chance to get this merged and released? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facterdb 0.8.1 introduced a SLES 15 SP1 fact set which doesn't have a
operatingsystem fact. This is due to bugs in facter 2.5. As facter 2.5
doesn't get maintance anymore, we need to fail safely here.
Fixes #3.