Fix choosing reply action #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we don't touch PostbackActionData in chatbotState because we don't want to change ChatbotPostbackHandlerParams; which makes calling postback more difficult
This was referenced Nov 19, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
MrOrz
changed the title
- Some execution do not wait for result and uses timeout to ensure completion - However these tests are vulnerable to parallel execution, which may cause timeout happen earlier than execution - This commit sets --runInBand in workflow file to ensure one test is run every time
Pull Request Test Coverage Report for Build 6922190714
💛 - Coveralls |
andyy0216
approved these changes
Nov 20, 2023
bil4444
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the release blocker found in 20231115 release test.
refactor(webhook): map state and payload in createPostbackAction
refactor(webhook): type yes/no postback handlers
return input satisfies neveris to ensure all input enum has its owncasein switch statement.Screenshot