Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(initState): typing gql and initState API response #355

Merged
merged 10 commits into from
Aug 15, 2023
Merged

fix(initState): typing gql and initState API response #355

merged 10 commits into from
Aug 15, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Aug 8, 2023 •
edited
Loading

  • try adding the first event handler type definition in types directory
  • typing gql and initState() handler
    • Removes credentials because node-fetch does not support credentials
      • we use x-app-secrets so it's not used anyway
      • LIFF implements its own gql (which uses Authorization header to talk to line bot graphql) so is not affected either
  • update typegen result with latest staging Cofacts API

@MrOrz MrOrz self-assigned this Aug 14, 2023
@coveralls
Copy link

coveralls commented Aug 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5863959814

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 90.686%
Totals Coverage Status
Change from base Build 5863858587: -0.4%
Covered Lines: 980
Relevant Lines: 1052
💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review August 14, 2023 07:17
@MrOrz MrOrz requested review from nonumpa and yhsiang August 14, 2023 07:17
yhsiang
yhsiang approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@yhsiang yhsiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrOrz
fix(initState): typing gql and initState API response
cd7b644
@MrOrz
Try defining d.ts file
61118db 
- but d.ts file with imports are not considered ambient and requires import
@MrOrz
fix: use ordinary ts file for types
5e9a956 
- also fixes util function types
@MrOrz
fix(gql): gql param type and update server types
3b94585 
- Include AI repsonse related fields
- fix gql search param type; it is sent to "query" in format(), which takes an map
- extract type for createAIReply
@MrOrz
fix(initState): document internal fields
c134e64 
- `event.input` is in added in handeInput()
- documents dummy 'server_choose' event
@MrOrz
fix(gql): rename mock so that jest can read
c9dd8cc
@MrOrz
fix(gql): update snapshot
8a13dc0 
- node-fetch does not support `credentials` at all
- we use x-app-secrets so it's not used anyway
- LIFF implements its own gql (which uses Authorization header to talk to line bot graphql) so is not affected either
@MrOrz
doc(types): add comment for ChatbotStateHandler
9df3455
@MrOrz
fix(types): follow event naming convention
a1a5b3b
@yhsiang yhsiang mentioned this pull request Aug 15, 2023
Merged
yhsiang
yhsiang approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@yhsiang yhsiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnson-liang johnson-liang merged commit b32f723 into master Aug 15, 2023
2 of 4 checks passed
@johnson-liang johnson-liang deleted the initstate-ts branch August 15, 2023 05:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhsiang yhsiang yhsiang approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrOrz @coveralls @yhsiang @johnson-liang