-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group message issues #244
Conversation
Pull Request Test Coverage Report for Build 1286
💛 - Coveralls |
46e0cf4
to
b1b7fe2
Compare
And fix bugs 1. Custom metrics isn’t sent 2. Room/Group member count should use their own api
…`Reply` / `Selected` / `<selected reply id>`
b1b7fe2
to
e3fddfb
Compare
); | ||
|
||
const visitor = ga(groupId, 'N/A', '', otherFields.source.type); | ||
|
||
visitor.set('cm1', groupMembersCount); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because chatbot may join/leave a group multiple times,
we should find the last Join
action of the Client Id
to get a more accurate Group Members Count
.
Don't know if there's a better way to handle this condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks for the note!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Let's get it to dev & staging ASAP.
@@ -49,6 +51,11 @@ export default async function processText(event, groupId) { | |||
return { event, groupId, replies }; | |||
} | |||
|
|||
if (event.input.toLowerCase() === LEAVE_KEYWORD) { | |||
await lineClient.post(`/${event.source.type}/${groupId}/leave`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this trigger leave webhook? If not, we may need to manually send ga
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does.
Fix remain issues from PR #238
Others