Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive article and reply text to Wayback Machine #344

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Sep 1, 2024

This PR fixes #136 .

We will use the Wayback Machine Save Page Now API to archive URLs extract from these content:

  • article text
  • article transcript text
  • reply text
  • reply reference

Refactor: use NodeJS typescript definition for NodeJS 18 (previously package-lock.json resolves to NodeJS 10's type and does not contain definition of new NodeJS APIs like fetch)

Testing

Submitting this to staging:
https://dev.cofacts.tw/article/2mpux6cst06ad

Triggers:
image

Job spn2-c500e35508b30770bcc231501135d371eec369d5 result:

@coveralls
Copy link

coveralls commented Sep 1, 2024

Coverage Status

coverage: 88.398% (+0.1%) from 88.287%
when pulling fbd6d80 on wayback-machine
into 1a74e5d on master.

@MrOrz MrOrz requested a review from nonumpa September 2, 2024 07:49
@MrOrz MrOrz self-assigned this Sep 2, 2024
@MrOrz MrOrz requested a review from bil4444 September 2, 2024 07:49
@MrOrz MrOrz merged commit 4857e9f into master Sep 4, 2024
5 checks passed
@MrOrz MrOrz deleted the wayback-machine branch September 4, 2024 15:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send new article & reply URLs to Wayback machine
3 participants