Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try implicit operator for method matching #149

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

israellot
Copy link
Contributor

This addresses #148

I believe it's fair because such calls would work seamless on actual C# code.

@codingseb
Copy link
Owner

Hye @israellot yes it looks nice and nothing seems to be break, all tests passes.
Maybe one or two tests could be added to ensure that we do not break this later as method override selection is not piece of cake so there is good risk that this part will change.

Anyway thank for this pull request.

I will already merge this.

@codingseb codingseb merged commit c403117 into codingseb:master Aug 24, 2022
@israellot
Copy link
Contributor Author

Thanks! No problem, just submitted the unit test as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants