Optional Event Information and Simplified UI #29
Conversation
Event details options
Event Details option and reduced the number of dropdowns
New entries for events fields and reduced complexity
events option added to readme
new features added
screenshot of simplified item options
image added
schema fieldsets imported from default to avoid issues in the search block plus will allow removing unnecessary code.
| start = `${parsedDate.toLocaleString( | ||
| 'en-US', | ||
| {hour: 'numeric', minute: 'numeric', hour12: true}, | ||
| )}`; |
There was a problem hiding this comment.
This should be done in some generic way, not to be attached to en-US locale always.
There was a problem hiding this comment.
changed locales to 'default' instead of 'en-US'
src/AdvancedListingBlockTemplate.jsx
Outdated
|
|
||
| if (item.end) { | ||
| const parsedDate = new Date(Date.parse(item.end)); | ||
| end = ` - ${parsedDate.toLocaleString('en-US', { |
There was a problem hiding this comment.
changed locales to default instead of 'en-US'
CHANGELOG.md
Outdated
| - Simplified Block side menu to reduce the number of collapsible accordions | ||
| - Simplified fields labels | ||
| - Move Heading information to the same location as default variants | ||
|
|
There was a problem hiding this comment.
do not modify the CHANGELOG file please, we handle this auth auto-changelog. Group your commits with prefixes like: "feat: Optional Event Date", "fix: simplified field labels", etc.
added srcSet and sizes to image to improve image size handleling by the browser make time locale default instead of en-US
removed changes I made to change in my previous PM
search block with advanced options
|
made a few changes including using srcSet for improved performance on slow internet and mobile devices |
|
@libargutxi @ionlizarazu review these functional changes please. |
|
I see many prettier related changes here, we should add our prettier config file to avoid such changes here. |
|
should I release this as a separate addon? |
…The srcset attribute should contain a list of image URLs separated by commas, but in this code, the URLs are separated by , and \n, which is not valid. ''
This version optionally displays event information, including the date, time and/or description. In addition, the UI of the variant block has been simplified by reducing the number of field sets to base plus 2 and making minor adjustments to field labels.