Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #43

Merged
merged 4 commits into from
Jul 21, 2021
Merged

Various fixes #43

merged 4 commits into from
Jul 21, 2021

Conversation

codereverser
Copy link
Owner

@codereverser codereverser commented Jul 19, 2021

  • classify transaction as REVERSAL when transaction is rejected due to mandate issues
  • ignore transactions with no units for capital gains calculations
  • support Franklin Templeton migration to CAMS RTA (while keeping the support for old PDF files intact). fixes Franklin Schemes not Returned #42

@codereverser codereverser added the bug Something isn't working label Jul 19, 2021
@codereverser codereverser self-assigned this Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #43 (f6dcfe6) into main (a32f3a8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   97.62%   97.66%   +0.03%     
==========================================
  Files          19       19              
  Lines        1053     1069      +16     
==========================================
+ Hits         1028     1044      +16     
  Misses         25       25              
Impacted Files Coverage Δ
casparser/analysis/gains.py 96.19% <100.00%> (+0.21%) ⬆️
casparser/cli.py 98.84% <100.00%> (+0.03%) ⬆️
casparser/process/cas_detailed.py 96.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32f3a8...f6dcfe6. Read the comment docs.

@codereverser codereverser merged commit 53cfa2a into main Jul 21, 2021
@codereverser codereverser deleted the fix/capital-gains branch July 21, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Franklin Schemes not Returned
1 participant