Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Default DB Connection to Model Connection #17

Closed
wants to merge 1 commit into from

Conversation

onlyu-bot
Copy link

This PR is to fix #16 by setting connection from default DB connection to the model's connection.

Set Connection from default DB connection to the model's connection.
@hivokas
Copy link
Member

hivokas commented Aug 22, 2020

Thanks for the PR!
Let's:

  • remove the connection property and argument from the constructor
  • let's get the connection directly inside table() method

@hivokas
Copy link
Member

hivokas commented Sep 9, 2020

@onlyu-bot fixed in 1.0.0 release

@hivokas hivokas closed this Sep 9, 2020
@onlyu-bot
Copy link
Author

@hivokas Thank you for the release! Sorry that I forgot to modify the connection property...omg...

@hivokas
Copy link
Member

hivokas commented Sep 9, 2020

No problem. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated factory return an empty array
2 participants