[App] Add presences list #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for coderdojobraga-blog canceled.
|
✅ Deploy Preview for coderdojobraga-web canceled.
|
✅ Deploy Preview for coderdojobraga-maintenance canceled.
|
✅ Deploy Preview for coderdojobraga-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Comment on lines
18
to
42
| type Event = { | ||
| id: string; | ||
| title: string; | ||
| location_id: string; | ||
| }; | ||
|
|
||
| type Lecture = { | ||
| id: string; | ||
| event: Event; | ||
| mentor: { | ||
| id: string; | ||
| first_name: string; | ||
| last_name: string; | ||
| photo: string; | ||
| }; | ||
| ninja: { | ||
| id: string; | ||
| first_name: string; | ||
| last_name: string; | ||
| photo: string; | ||
| }; | ||
| summary: string; | ||
| notes: string; | ||
| attendance: string; | ||
| }; |
There was a problem hiding this comment.
This type definitions are more generic than this page. I think we can move them to the bokkenjs package.
| useEffect(() => { | ||
| generateData(); | ||
| }, [selectedLectures]); | ||
| console.log(selectedLectures); |
There was a problem hiding this comment.
When I finish editing a given session, and then move to a different one and back to the one I just edited, the changes are not being reflected. I believe it is because you are not updating your local copy of the lecture after you save it.
Also rebase with main
git rebase origin/main
git push -f # Only force push when strictly necessary :)
That should fix the Link Checker action
| api | ||
| .listEvents() | ||
| .then((response: any) => setEvents(response.data)) | ||
| .catch(() => {}); |
There was a problem hiding this comment.
Add a notification for this error. The worst thing you can do is having the request fail silently.
| api | ||
| .getLocations() | ||
| .then((response: any) => setLocations(response.data)) | ||
| .catch(() => {}); |
Comment on lines
208
to
223
| <Upload | ||
| name="avatar" | ||
| accept="image/*" | ||
| beforeUpload={(file) => { | ||
| getBase64(file, (imageUrl: any) => setAvatar(imageUrl)); | ||
| return false; | ||
| }} | ||
| onRemove={() => setAvatar(null)} | ||
| multiple={false} | ||
| maxCount={1} | ||
| showUploadList={{ | ||
| showDownloadIcon: false, | ||
| showPreviewIcon: false, | ||
| showRemoveIcon: true, | ||
| }} | ||
| > | ||
| <Button icon={<UploadOutlined />}>Selecionar</Button> | ||
| </Upload> | ||
| <ImgCrop> | ||
| <Upload | ||
| name="avatar" | ||
| accept="image/*" | ||
| beforeUpload={(file) => { | ||
| getBase64(file, (imageUrl: any) => setAvatar(imageUrl)); | ||
| return false; | ||
| }} | ||
| onRemove={() => setAvatar(null)} | ||
| multiple={false} | ||
| maxCount={1} | ||
| showUploadList={{ | ||
| showDownloadIcon: false, | ||
| showPreviewIcon: false, | ||
| showRemoveIcon: true, | ||
| }} |
There was a problem hiding this comment.
Aren't these changes duplicated from #181 ? If so it should be removed as it will be automatically updated when that PR gets merged
Comment on lines
42
to
55
| // const onFinish = (values: any, lectureId: string) => { | ||
| // api | ||
|
|
||
| // .updateLecture(lectureId, values) | ||
| // .then(() => { | ||
| // notifyInfo("Os dados da sessão foram atualizados com sucesso", ""); | ||
| // }) | ||
| // .catch((error) => { | ||
| // notifyError( | ||
| // "Ocorreu um erro", | ||
| // "Não foi possível atualizar os dados da sessão" | ||
| // ); | ||
| // }); | ||
| // }; |
There was a problem hiding this comment.
Remove this if you no longer need it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a page that consists of being a list of attendance of the sessions.