Update VS Code to 1.92.1 #6941
Merged
Update VS Code to 1.92.1 #6941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
2 times, most recently
from
fe50409
to
6bac345
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6941 +/- ##
=======================================
Coverage ? 72.62%
=======================================
Files ? 31
Lines ? 1903
Branches ? 411
=======================================
Hits ? 1382
Misses ? 441
Partials ? 80
Continue to review full report in Codecov by Sentry.
|
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
from
e14e628
to
56460cb
Compare
It looks like the bootstrap files are now bundled so we can no longer require them. We could make them included again, but maybe it is better to go through the main entrypoint anyway because it includes some nls stuff which is maybe necessary. This also fixes what looks like a bug where we could create two servers if two requests came in. I am not sure what the practical consequences of that would be, but it will no longer do that.
Unfortunately, VS Code will not load with this. It seems to be because
`this` is being used in static properties, and it becomes `void 0` for
some reason under the es2020 target. For example:
static PREFIX_BY_CATEGORY = `${this.PREFIX}${this.SCOPE_PREFIX}`;
becomes
AbstractGotoSymbolQuickAccessProvider.PREFIX_BY_CATEGORY = `${(void 0).PREFIX}${(void 0).SCOPE_PREFIX}`;
Which, obviously, will not work.
Older versions of Safari (and maybe other browsers) are likely affected.
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
5 times, most recently
from
6a9bd85
to
fc4a977
Compare
code-asher
force-pushed
the
asher/vscode-1.92.0
branch
from
fc4a977
to
cf141c3
Compare
I think maybe because of the dropped es2020 patch that Webkit is now failing because it is too old.
I am not sure what is going on but some tests on Webkit are timing out and it seems the page is loaded but something is still trying to download. Not good either way, but for now trying to at least get the tests passing.
|
yay |
|
Functionality [modified by patches] tested and found to work:
Workspaces and Jupyter Notebooks also work fine:
|
|
Huzzah thank you for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6920
When building locally, bootstrap-node.js was missing...not sure what is going on there.Edit: Looks like the files are bundled now (intoserver-main.js). We could unbundle them again but I opted to call intoserver-main.js(took a small amount patching) since it also seems to do some nls stuff which is maybe important. Also it handles all that VS Code-specific environment variable stuff we were copying before.The es2020 patch does not work. It results in invalid code. Not sure if this is a bug with whatever is doing the transpilation (tsc?) but unfortunately I had to remove it.
Still need to figure out what to do about the language stuff.I am going to see if our patch is still necessary.Edit: It is, but something about it does not quite work.Edit 2: Figured it out, looks like the browser needs a file that sets translations into a global so I am now generating that file locally since we cannot use Microsoft's CDN to pull down translations like how they have it set up.Also need to look into the proxy URI test failing.A flake? Works fine locally.